search

mgear-dev / mgear4

mGear v.4.x.x (python 3 ready) https://mgear4.readthedocs.io
MIT License
259 stars 91 forks source link

Made a custom attribute for rotateOrder to store a default value in a controller. #328 #338

Closed joji2468ng closed 7 months ago

joji2468ng commented 7 months ago

https://github.com/mgear-dev/mgear4/issues/328

Here is the reported issue in the forum. http://forum.mgear-framework.com/t/mgear-viewport-menu-resets-the-rotarte-order-always-to-xyz/3574

miquelcampos commented 7 months ago

@joji2468ng I am very sorry, I didn't expect you will jump on this so fast! But the solution provided will break back compatibility with all the previously generated rigs. We can't lock now the original rot order attr. My idea was to add a new attr to store the default rot order as metadata, and later update the reset tools to use it if the control has it. That will keep the improvement hidden from the user and compatible with old rigs and ongoing productions that want to update to the latest mgear. In general, a solution that needs to update all the components should be the last option. I feel terrible to not merge this after all your hard work, but I can't 🙇

joji2468ng commented 7 months ago

Thank you for the feedback, I will follow your idea and fix it with metadata!

miquelcampos commented 7 months ago

Thanks @joji2468ng Before start will be good to prepare a little bullet list with the parts that we want to change, before committing any change 🙏 Just to be sure. I don't want to waste your time 🙇