search

mgear-dev / mgear_dist

mGear v.3.x.x distribution repository
http://www.mgear-framework.com/
MIT License
184 stars 53 forks source link

Update submodules urls, move from ssh to https. #41

Closed 4lxDN3 closed 5 years ago

4lxDN3 commented 5 years ago

Should solve the issue: https://github.com/mgear-dev/mgear_dist/issues/40

Regards,

miquelcampos commented 5 years ago

@4lxDN3 Thanks!! @jdrese can you check it? For me looks good

4lxDN3 commented 5 years ago

@miquelcampos U're welcome.

jdrese commented 5 years ago

Hello @miquelcampos @4lxDN3

Sorry for the late reply. There is indeed no major issue on changing credentials from ssh to https. In the past GitHub comunity recommended SSH for security reasons on projects more than anything else but now they recommend HTTPS as it is easier for newer setups and people who don't know what ssh is.

Https has as well another extra advantage/disadvantage (depending on how you see it) but those are less likely to get blocked by firewalls setups.

Anyway thanks @4lxDN3 for the change.