Closed rafmelo closed 3 years ago
It seems what's confusing here is that there are two lip riggers. The one is the legacy lips rigger which takes a .lips file with a different data arrangement than the new one rigbits.facial_rigger.lips_rigger uses. This is not a bug but rather the config from the new rigbits.facial_rigger.lips_rigger saved to disk and the module from the legacy lips rigger rigbits.lips_rigger used to load the new .lips config which does not contain the "lips" key, hence the keyError.
I didn't see this issue until now. There are different commands for the new style configuration. I think some examples and a note about the difference should be added to the documentation in both modules.
from mgear import rigbits
# OLD LEGACY eye_rigger and lips_rigger tool
rigbits.eye_rigger.eyesFromfile(eyesConfigPath)
rigbits.lips_rigger.lipsFromfile(lipsConfigPath)
# NEW "facial_rigger" module
rigbits.facial_rigger.eye_rigger.rig_from_file(eyesConfigPath)
rigbits.facial_rigger.lips_rigger.rig_from_file(lipsConfigPath)
Thanks guys! It's been a while, I figured I might have posted this at the wrong place. :P
@chris-lesage I am removing the old face rigger for mgear 4.0. if the issue is only duplicity, maybe we can close this issue?
@miquelcampos yes this can be closed. I'll keep a task reminder for myself to add a note to the 3.x documentation, if there are plans to keep that updated. And examples of usage in the 4.x documentation.
rigbits.lips_rigger.lipsFromfile / eye_rigger.eyesFromfile don't seem to work with new json config files from 3.6.0. They still work with old config files generated with mGear 3.0.3, though.
To Reproduce Export json config files for the lips and eyes using the new Facial Rigger on mGear 3.6.0 Try to build using mgear.rigbits.lips_rigger.lipsFromfile(path)
Screenshots![image](https://user-images.githubusercontent.com/48359769/86965564-c32aa200-c135-11ea-9ef1-7e3c97282d02.png)