search

mgear-dev / rigbits

Rigging tools and boilerplate functions for rigging.
MIT License
10 stars 14 forks source link

Simplify the behavior of the blinks #32

Closed chris-lesage closed 5 years ago

chris-lesage commented 5 years ago

Remove the upper blink clamping, and make the upper and lower blinks act like the original behavior, just separated upper and lower.

The original attrs (blink and blinkHeight) still exist and act the same as before.

tokejepsen commented 5 years ago

Took this for a spin today. Great work!

I would like to see if we could fix a small issue atm though. The lid seal is slightly off when just using the blink attribute, but with upper and lower lid turned on it gives the same deformation as before with just the "blink" attribute. See the gif for visual explanation.

May 13 2019 8_45 AM

chris-lesage commented 5 years ago

This explains so much. I've been seeing that gap on all of our characters, and thought I was choosing the wrong edge loops. I must be missing a blendshape somewhere. I'll fix this as soon as possible. Thanks!

tokejepsen commented 5 years ago

This looks great to me! Have tested it and works as expected, think the only thing standing in the way of a merge is incrementing the version. Since its backwards compatible now, you just need to increment the minor version to 3.3.0

chris-lesage commented 5 years ago

Since its backwards compatible now, you just need to increment the minor version to 3.3.0

ELI5? Where and how would I do that? Otherwise, if whoever is merging it can do that, go ahead.

tokejepsen commented 5 years ago

https://github.com/chris-lesage/rigbits/blob/separate_eyes/scripts/mgear/rigbits/version.py

chris-lesage commented 5 years ago

Cool thanks, done!