search

mgear-dev / shifter_classic_components

Components library for Shifter
MIT License
1 stars 10 forks source link

foot_bk_01 component roll_ctrl issue #68

Closed JaschaW closed 5 years ago

JaschaW commented 5 years ago

Describe the bug When toggling the "use roll control" checkbox under the settings tab of the foot_bk_01 component, it does not update on the actual component.

To Reproduce

  1. Create foot_bk_01 component
  2. Open component settings tab, toggle "use roll ctl" and build.
  3. Still builds with roll ctl.

Screenshots mgear_foot_bk_01

Solution In the component guide module, the method create_componentConnections has a string value "neutralpose" which is the incorrect name. I found that by changing the name to "useRollCtl" as it was named in addParameters method.

mgear_foot_bk_01_code

miquelcampos commented 5 years ago

Hi @JaschaW thanks for the feedback! Do you feel like sending a pull request? If not I will do it :) Thanks!

JaschaW commented 5 years ago

Hi @miquelcampos you are most welcome! Happy to contribute, even in the smallest of ways :) I have sent a pull request for this. First time doing this, so hope I did it correctly. If not, please let me know! I am happy to resolve any issues.

miquelcampos commented 5 years ago

fixed here: https://github.com/mgear-dev/shifter_classic_components/pull/61