Request to overtake maintainership

[osnard]

Hello!

My colleagues and me have already applied some changes in our fork (https://github.com/hallowelt/mediawiki-extensions-DrawioEditor). We are planning to add additional functionality. If you don't mind, we'd officially overtake the maintainership and also change the download link on https://www.mediawiki.org/wiki/Extension:DrawioEditor

Best regards!

[willstott101]

It appears issues are disabled on your fork, which would certainly be far from ideal as a new maintained location for the extension.

[osnard]

We will move this to the public WMF git repository. By this issues can be tracked using WMF Phabricator (https://phabricator.wikimedia.org/), contributions and code review will be handled within the WMF Gerrit insfrastructure (https://www.mediawiki.org/wiki/Gerrit)

[osnard]

This extension is now [1] maintained on WMF gerrit. Please file any bug report at https://phabricator.wikimedia.org/tag/mediawiki-extensions-drawioeditor/

[1] https://www.mediawiki.org/w/index.php?diff=4013201&oldid=4009652&title=Gerrit/New_repositories/Requests/Entries&type=revision&diffmode=source

[bohrsty]

I left a comment in #10, that I opened a change on gerrit (https://gerrit.wikimedia.org/r/c/mediawiki/extensions/DrawioEditor/+/652185), has anyone noticed that change? Is there anything I should do, to get that change reviewed and merged?

[osnard]

I have seen it, thank you! I will review/merge it as soon as possible.

[bohrsty]

thanks and no rush, I only couldn't see any progress...

[osnard]

I have amended you change a little bit. https://gerrit.wikimedia.org/r/c/mediawiki/extensions/DrawioEditor/+/652185/1..8

It's mainly two things:

• Changed the config var name to match code from another existing branch (REL1_31) that for some reason did not make it into the newer branches. This is to keep up compatibility.
• Removed the config var for the interface language. Instead I am not using the client side user information from MediaWiki to set the language properly.

I have also added the local flag. This is also coming from another branch that had a configureable backend url.

If you have no objections to the changes I did to your code, I'd merge it within the next few days.

[bohrsty]

thanks a lot, you have more detailed experiences with that code, so I'm completely fine with your changes...

I'm not sure, what is the exact difference between local=1 and offline=1 setting... according to the docs (https://www.diagrams.net/doc/faq/supported-url-parameters) I removed the individual settings for remote storage (db=0, gapi=0 and od=0) and added the offline=1 setting... if local=1 has the same effect, you could remove the offline=1 setting completely (or mix that settings, if necessary)...

[bohrsty]

hello @osnard, is there any problem with merging the change?

[bohrsty]

ping...

[osnard]

Hi! Sorry, I have asked a colleague to take care of this. Will check and give feedback asap.

[osnard]

Okay, so it looks like your proposed changes have been merged in another commit that also had some additional changes

• You change: https://gerrit.wikimedia.org/r/c/mediawiki/extensions/DrawioEditor/+/652185/
• Change of my colleague: https://gerrit.wikimedia.org/r/c/mediawiki/extensions/DrawioEditor/+/659221

Can you please check if your changes are applied properly (I believe they should be) and maybe abandon your original change?

[bohrsty]

Thanks, from code view in gerrit, all changes are include in 659221, I'll test the commit in a test installation and give feedback here... I abandoned my original change...

[bohrsty]

Works like expected, thanks to anyone making this work...