mgechev / codelyzer

Static analysis for Angular projects.
http://codelyzer.com/
MIT License
2.45k stars 233 forks source link

i18n rule check-text does not work #497

Open Martin-Luft opened 6 years ago

Martin-Luft commented 6 years ago

"i18n": [true, "check-text"] does not work for this examples:

<label class="checkbox-inline" i18n="Bearbeiten eines Artikels|Veröffentlichung im Internet?">
  <input name="article.publish" [(ngModel)]="article.publish" role="edit" type="checkbox">
  Veröffentlichen
</label>

edit-article.component.html[35, 110]: Each element containing text node should have an i18n attribute

or

<p class="text-muted" i18n="Aktueller Anwender|Auflistung der Rollen" *ngIf="user$ | async as user; else userIsLoading">{{user.firstName}} {{user.lastName}} (Rollen: {{user.roles}})</p>
<ng-template #userIsLoading i18n="Aktueller Anwender|Daten werden geladen">Anwender wird geladen...</ng-template>

ERROR: user.component.html[2, 75]: Each element containing text node should have an i18n attribute

And can you please explain which codelyzer rules are stable and production ready and which not? For example you said that the no-unused-css rule is not stable (here https://github.com/mgechev/codelyzer/issues/364) and this i18n rule seems to be unstable as well.

mgechev commented 6 years ago

Thanks for reporting the issue. I will add test for your specific examples and fix the issues. The i18n rules were recently added, we are still figuring out the correct behavior in some cases.

wKoza commented 6 years ago

There is an issue opened concerning the status of each rule #408. In the meantime, maybe can we a this status in our Readme.

mgechev commented 6 years ago

I'll update the readme in a sec.

Martin-Luft commented 6 years ago

@mgechev you missed the following rules:

import-destructuring-spacing, pipe-naming and no-output-named-after-standard-event.

@mgechev and the rules page (http://codelyzer.com/rules/) doesn't contain:

trackBy-function and no-output-named-after-standard-event

Should I open a new issue for that?

wKoza commented 6 years ago

Yes @Martin-Wegner , you can !

Martin-Luft commented 6 years ago

https://github.com/mgechev/codelyzer/issues/501