mgechev / codelyzer

Static analysis for Angular projects.
http://codelyzer.com/
MIT License
2.45k stars 233 forks source link

[feature request]: Allow aria-label to suppress template-accessibility-elements-content violation #993

Open abzats opened 3 years ago

abzats commented 3 years ago

Describe the bug

I'm facing an issue when I don't want to set explicit text content for a button element but I want to use aria-label for assistive technologies instead. In my current situation, I have a directive that adds icons to the button but without text.

Would it be possible for template-accessibility-elements-content to consider aria-label to be an acceptable alternative (either by default or as a rule option)?

Context and configuration

Please share:

Expected behavior

<button class="btn-close" aria-label="close></button> should NOT produce an error.

Additional context

I believe a similar question about "aria-label" support might be raised to all others template-accessibility-* rules.

rafaelss95 commented 3 years ago

@abzats I'm afraid we can't support this in Codelyzer as TSLint is out, you could open this in https://github.com/angular-eslint/angular-eslint/issues instead.