Closed mik-laj closed 7 years ago
Added comments. I can merge once you address them. Thanks for the PR!
@mik-laj added two more comments.
@mik-laj would you fix the errors and make sure your build passes (gulp build
).
@mgechev I think the tests are not exactly accurate.
File: https://github.com/mgechev/javascript-algorithms/blob/master/test/sorting/sort.testcase.js#L25 define 4 test cases, but some are checking the result of the function, and some old references array.:
@mik-laj thanks for the PR! Will update the list of contributors in the next a couple of days.
Hi my friend.
What do you think about it? Javascript is not just a classic language, but it already has functional programming elements. This allows you to express some problems in a clearer way.
Thanks in advance.