[gulpUpdate]: Updated Gulp dependency to fix build failure

mgechev / javascript-algorithms

💻 JavaScript implementations of computer science algorithms

https://mgechev.github.io/javascript-algorithms/

MIT License

7.83k stars 1.28k forks source link

[gulpUpdate]: Updated Gulp dependency to fix build failure #177

Closed twosdai closed 3 years ago

twosdai commented 3 years ago

Hey I saw your build was failing in CI, It was also failing locally. I updated the Gulp dependency and refactored the gulp.js file a bit.

Additionally there were some linting errors which failed the build so I fixed those as well

twosdai commented 3 years ago

Im not super familiar with travis ci. It would make it easier to not have to maintain two different package integrity sources, yarn.lock and package-lock.json. I could look into submitting a pull request with a refactor for travis ci if you wanted that.

mgechev commented 3 years ago

Thank you for the improvement 🙇🏼‍♂️

mgechev commented 3 years ago

@twosdai you're correct. Having both package-lock.json and yarn.lock is a mistake. Feel free to remove one of them.