search

mgechev / ngrev

Tool for reverse engineering of Angular applications
MIT License
1.57k stars 106 forks source link

VSCode extension version #51

Closed bampakoa closed 3 years ago

bampakoa commented 5 years ago

Hi,

Thanks very much for this awesome tool! Are there any plans to release it as a VSCode extension also? It should be really handy, especially for newcomers in a project, to take a quick look at the structure while navigating the code.

Thanks!

mgechev commented 5 years ago

It'd not have the bandwidth for that. I'd love to reference an extension if anyone is planning to implement it.

bampakoa commented 5 years ago

It'd not have the bandwidth for that

@mgechev Could you please clarify what do you mean?

mgechev commented 5 years ago

I would not have the time to implement a VSCode plugin for ngrev, but I agree this is a fantastic feature that you suggested.

If you think you'd be able to introduce VSCode plugin in this repo, I'd love to reopen the issue so we can track the progress. Also, if restructuring of the source code will simplify the implementation of a VSCode plugin in a separate repo, let me know. We can track this in another issue.

bampakoa commented 5 years ago

@mgechev thanks for the clarification. Yes, I would definitely be interested on this to help. I think that it would benefit the Angular community :smiley:

bampakoa commented 5 years ago

@mgechev if you could re-open issue to fire up the discussion, that would be great. Thanks!

bampakoa commented 5 years ago

@mgechev we could be inspired by Angular Console repo about the structure. It currently uses Nx but I think we could equally incorporate Angular CLI for this.

bampakoa commented 5 years ago

hey @mgechev . Just to let you know that I am currently working to submit an initial version of a PR for this.

bampakoa commented 5 years ago

@mgechev I was thinking to use Nx for structuring the repo, as in Angular Console, but I have some second thoughts. Let's use Angular CLI projects feature and keep it simple for now.

bampakoa commented 5 years ago

@mgechev the application imports Electron artifacts directly from the electron package which makes it tightly coupled with the Electron renderer. We could do one of the following to decouple it:

  1. Supply a custom provider with Inject for every artifact that we import, such as ipcRenderer and remote, as described here .
  2. Use a 3rd party library such as ngx-electron and replace it with an all-in-one custom provider.

What do you think?

mgechev commented 3 years ago

Closing for now. If there's progress in the future, please open a PR or another issue.