resolve #867: remove k[A-Z][A-Za-z\d]*$ sub-rule from `var-naming`

mgechev / revive

🔥 ~6x faster, stricter, configurable, extensible, and beautiful drop-in replacement for golint

https://revive.run

MIT License

4.73k stars 276 forks source link

resolve #867: remove k[A-Z][A-Za-z\d]*$ sub-rule from `var-naming` #871

Closed martinsirbe closed 1 year ago

martinsirbe commented 1 year ago

This PR proposes the removal of k[A-Z][A-Za-z\d]*$ sub-rule from var-naming, as it doesn't clearly justify the reason for the check and fails to properly tackle any potential issues with Hungarian notation.

The emphasis is on ensuring clarity, reducing confusion, and enhancing the overall user experience for revive users.

The sub-rule originates from golang/lint and has in the past led to false positives and confusion, see https://github.com/golang/lint/issues/258.

Closes #867

chavacava commented 1 year ago

Hi @martinsirbe, thanks for the PR! To go on with the merge, it will be necessary to update the tests of the rule to stop testing the case we are not logger supporting.