mgechev / revive

🔥 ~6x faster, stricter, configurable, extensible, and beautiful drop-in replacement for golint
https://revive.run
MIT License
4.69k stars 273 forks source link

variable to skip package name checks #941

Closed gburanov closed 7 months ago

gburanov commented 7 months ago

It is a pity that two functionalities are merged together in the rule rule.var-naming - checking variable and package naming.

In our company we find variable naming check very useful, but we do not want to check for packages naming.

Therefore I propose to add option to skip package name checks

chavacava commented 7 months ago

HI @gburanov, thanks for the PR, I've left some comments in the code

chavacava commented 7 months ago

@gburanov Please also:

  1. update README.md and RULES_DESCRIPTIONS.md to document the new parameter.
  2. Add testcases to check the parameter is working as expected
gburanov commented 7 months ago

@chavacava I made the changes you suggested

chavacava commented 7 months ago

Thanks @gburanov !