Fix a performance regression #995

[dominiquelefevre]

• Support go workspaces when detecting the go version.
• Do not invoke go list for every package.

Closes #995

[ldez]

I think you should add a better PR title.

I still need a way to fully bypass the Go detection and set a Go version.

[dominiquelefevre]

Commit titles and messages contain enough information. If you have a specific PR title in mind, feel free to propose it.

Go version chooses the correct set of warnings to enable, so the version detection is a must.

[ldez]

Commit titles and messages contain enough information. If you have a specific PR title in mind, feel free to propose it.

I suggest: "fix: performance regression" And add "Fix #995" inside the PR description.

Go version chooses the correct set of warnings to enable, so the version detection is a must.

The Go detection is done inside golangci-lint, golangci-lint doesn't work as revive, so a way to set the Go version is a requirement for us.

[dominiquelefevre]

The Go detection is done inside golangci-lint, golangci-lint doesn't work as revive, so a way to set the Go version is a requirement for us.

I am not familiar with the way golangci-lint integrates revive and how you intend to use it. Please send patches to add hooks that you need.

[ldez]

I am not familiar with the way golangci-lint integrates revive and how you intend to use it.

We need to specify the Go version through this function:

func (l *Linter) Lint(packages [][]string, ruleSet []Rule, config Config) (<-chan Failure, error) {

[dominiquelefevre]

Added an option to override the language version detection to struct Config. @ldez, it should fit your description.

[dominiquelefevre]

Ping @denisvmedia, @chavacava, @ldez.

[dominiquelefevre]

Hey, is this repo alive? Can somebody review the PR? @denisvmedia , @chavacava , @ldez ?

[chavacava]

Hi @dominiquelefevre, thanks for the PR. I'm abroad with restricted internet and PC access. I'll check the PR as soon as I'm back home (next weekend)