search

mgedmin / findimports

Static analysis of Python import statements
MIT License
117 stars 16 forks source link

Add option to ignore imports from the Python stdlib #18

Closed Nicolas-Reyland closed 2 years ago

Nicolas-Reyland commented 2 years ago

I would like to add an option to ignore imports of the python standard library.

Nicolas-Reyland commented 2 years ago

I just wrote a 'prototype' version. I would just like to know if you would appreciate such an option. If this is not the case, I won't have to improve my code/write tests, etc.

Nicolas-Reyland commented 2 years ago

If you plan to do so, please do not merge this yet. There is still some work to be done. Some edge cases are not handled properly.

mgedmin commented 2 years ago

The feature sounds good, but I'll also want a change note in CHANGES.rst.

Nicolas-Reyland commented 2 years ago

This look all good to me. Feel free to review/change my code.

Nicolas-Reyland commented 2 years ago

I've resolved all the issues. Please let me know if there's anything else !

Nicolas-Reyland commented 2 years ago

Ok, I pushed my edits to the wrong branch .... let me fix this

Nicolas-Reyland commented 2 years ago

Ok, now everything seems fine. Let me know if there's anything else

mgedmin commented 2 years ago

Thank you!

mgedmin commented 2 years ago

Merged and released findimports 2.2.0