search

mgedmin / objgraph

Visually explore Python object graphs
http://mg.pov.lt/objgraph/
MIT License
753 stars 72 forks source link

Support old-style class names. And support shortname logic properly everywhere #16

Closed mikelambert closed 9 years ago

mgedmin commented 9 years ago

Oh, my good point.

The only thing that worries me is that some proxies out there masquerade their class. I'd rather use type(obj) but fall back to obj.__class__.__name__ if the type is types.InstanceType.

Also, this ought to have a test (one that's skipped on Python 3 since Python 3 has no old-style classes).

mikelambert commented 9 years ago

Not sure if github re-notifies you when I add more changes to the pull request. But thanks for the feedback, I've made the changes you've requested.

mgedmin commented 9 years ago

Not sure if github re-notifies you when I add more changes to the pull request

It doesn't. Thanks for the ping!

mikelambert commented 9 years ago

Ok cool, re-ping.