mgedmin / objgraph

Visually explore Python object graphs
http://mg.pov.lt/objgraph/
MIT License
753 stars 72 forks source link

Run existing unittest-like doctests as unittests. #19

Closed pcostell closed 9 years ago

pcostell commented 9 years ago

Also adds some framework for expanding show_graph test coverage.

Addresses some of mgedmin/objgraph#11.

mgedmin commented 9 years ago

Looks good to me, other than some minor style things.

One thing I'm not sure if even worth mentioning: I'm used to self.assertEqual(f(args), expected_result) and you appear to be used to self.assertEqual(expected_result, f(args)). I don't know if one's more common than the other. It probably doesn't matter anyway.