mgedmin / objgraph

Visually explore Python object graphs
http://mg.pov.lt/objgraph/
MIT License
753 stars 72 forks source link

Add param for output steam #24

Closed d-sun-d closed 8 years ago

d-sun-d commented 8 years ago

Now user can specify uotput stream.

I used lib with this modification in case where debug cann't be in sys.stdout

mgedmin commented 8 years ago

Thank you for the pull request!

I think output_stream is a bit too long. Let's call it file, like the Python 3 built-in print(..., file=sys.stdout) function.

The Travis CI build failure is caused by PEP-8 warnings:

./objgraph.py:172:80: E501 line too long (94 > 79 characters)
./objgraph.py:201:80: E501 line too long (84 > 79 characters)
./objgraph.py:242:80: E501 line too long (85 > 79 characters)
make: *** [lint] Error 1

and renaming output_stream to file should fix two of them. The third long line will need some wrapping.

d-sun-d commented 8 years ago

fix name and split big line

mgedmin commented 8 years ago

Thank you!