search

mgedmin / zodbbrowser

ZODB browser
http://launchpad.net/zodbbrowser
Other
19 stars 6 forks source link

Add new features #19

Closed thefunny42 closed 9 years ago

thefunny42 commented 9 years ago

We added a few extra features, that unfortunately only works for history free database. We did use all of those with a Relstorage database, history free. The outline is:

I am sure that will spur a lot of questions and I can answer all of them here.

mgedmin commented 9 years ago

Would you be willing to split this into a series of smaller pull requests, based on master?

mgedmin commented 9 years ago

Add support to browser objects by relations between them

If this means what I think it means (i.e. show me all objects that point to this one), then it's something I've always wanted to have.

Add support to find missing objects (POSKey error)

This doesn't seem to be in scope for ZODBBrowser, although I can imagine how it can be helpful, when combined with the previous feature.

Improve the rendering of missing objects

This is an excellent thing to do! It's where I would start when splitting up this into smaller PRs.

Add support to search for a python class within a database

This is interesting! And if we have search of one kind, why not have a search for all POSKeyErrors?

Add (using the first feature) a pack script to RelStorage based databases.

This seems out of scope for ZODBBrowser. Also, why is it needed? Doesn't RelStorage have its own packing facilities?

mgedmin commented 9 years ago

I've looked through the code, and there are no major problems with it. (Other than the failing Travis tests, of course. And I skipped the RelStorage packing bits.)

thefunny42 commented 9 years ago

I will close this request and make new branches with smaller requests.