Move statement-local warnings behind another flag

mgehre / llvm-project

The home of the clang-based implementation of lifetime safety warnings.

39 stars 4 forks source link

Move statement-local warnings behind another flag #50

Closed mgehre closed 5 years ago

mgehre commented 5 years ago

So they can be disabled separately, as requested by Richard. fyi @Xazax-hun

mgehre commented 5 years ago

@Xazax-hun Would you be able to move the rest of our statement-local warnings behind that flag? I'm not exactly sure about the logic yet. Would we need to sprinkle if(IsGslPtrInitWithGslTempOwner) around Diag(DiagLoc, diag::warn_ret_stack_addr_ref) and other diags?

Xazax-hun commented 5 years ago

Yeah, unfortunately, they are not all behind the same flag, because there are some logic reused between all those warnings. I think I have something slightly different in mind.

mgehre commented 5 years ago

This is now partly implemented.