search

mgeier / insipid-sphinx-theme

:yawning_face: An insipid theme for the Sphinx documentation generator.
https://insipid-sphinx-theme.readthedocs.io/
BSD 2-Clause "Simplified" License
39 stars 4 forks source link

Menu should collapse on mobile device after selecting a page #53

Closed lsaffre closed 3 years ago

lsaffre commented 3 years ago

On a mobile device, when I tap the hamburger button top expand the menu, then tap one of the menu entries, insipid opens the related page but does not automatically also collapse the menu. Which is irritating on a mobile device because the menu takes the whole screen width and thus hides the content. I need to tap the hamburger button again (so that the menu collapses) in order to get to my page.

lsaffre commented 3 years ago

Matthias pointed out that (1) the issue is only for pages with a single title and (2) even then I can tap a second time on the same title to make the menu collapse. That's indeed already a quite satisfying workaround.

mgeier commented 3 years ago

Does #54 what you want?

It doesn't work on the main page if there are multiple links (like "Table of Contents" and the link in the logo), but on the other pages it should work as expected.

lsaffre commented 3 years ago

Yes, works perfectly for me! This is great!

mgeier commented 3 years ago

OK, thanks for testing, I've just made a new release 0.2.7 which includes this change.