mgeier / insipid-sphinx-theme

:yawning_face: An insipid theme for the Sphinx documentation generator.
https://insipid-sphinx-theme.readthedocs.io/
BSD 2-Clause "Simplified" License
39 stars 4 forks source link

Distance between h1 and previous/next buttons to large on mobile #58

Closed hagenw closed 2 years ago

hagenw commented 3 years ago

When using the theme on a desktop the space between the main title and the next and previous buttons looks fine to me, but on a mobile it seems a little bit too much.

image

mgeier commented 3 years ago

I agree.

I guess we could also reduce the space on wide screens.

We could probably remove (or reduce) the padding-top of div.body?

Please note that it is theoretically possible to have content before the first headline, see e.g. https://insipid-sphinx-theme.readthedocs.io/en/0.2.7/showcase/sections.html.

mgeier commented 3 years ago

BTW, there is a "breadcrumbs" option that should also be considered when changing the spacing.

I've just created a new branch with an example configuration that includes the "breadcrumbs" feature: https://insipid-sphinx-theme.readthedocs.io/en/breadcrumbs/

mgeier commented 2 years ago

I've created #71 to hopefully solve this issue.

I've also removed some space at the top and bottom of the previous/next links.

Is that enough?

hagenw commented 2 years ago

It now looks like this

image

The distance is reduced from ~105 pixels to ~75 pixels. I think this should be sufficient.

The space on top of the next and previous buttons is now slightly too small in my opinion, maybe you could reduce it by only half the current value?

mgeier commented 2 years ago

Yeah, I thought it would be OK, but now that you mention it, I see that the space is too small.

In b86bbabf65d3aff95c47e33e0dedbb2362bd2fed, I've kept the top padding and only removed the bottom padding. What do you think about that?

Here's the preview: https://insipid-sphinx-theme--71.org.readthedocs.build/en/71/

hagenw commented 2 years ago

Yes, that looks good to me.

mgeier commented 2 years ago

OK, thanks, I've merged #71.