Separate parse_log() function for use in "with" statement

mgeier / sphinx-last-updated-by-git

:watch: Get the "last updated" time for each Sphinx page from Git

BSD 2-Clause "Simplified" License

44 stars 9 forks source link

Separate parse_log() function for use in "with" statement #35

Closed mgeier closed 2 years ago

mgeier commented 2 years ago

This way, the subprocess is always closed, even in case of an error.

Not doing this isn't a big deal, but it caused warnings to be displayed. And I think we should try to not cause any warnings in the automated tests. This should also make it easier for downstream packages to turn on warnings.