search

mgenev / how-to-sane

A demonstration of how to use the SANE stack
http://howtosane.ninja
MIT License
163 stars 22 forks source link

Minor sails unit test changes. Added barrels. #72

Closed Globegitter closed 9 years ago

Globegitter commented 9 years ago

Since I have already done the work @mgenev I thought I would make a PR out of it so we can see what is useful in here and what not.

I changed the tests to use sails-disk so they would work in any environment. I guess one possible drawback here is it would not catch adapter specific errors (such as the many-to-many mongo error).

Deactivated all the hooks we don't need and added some barrel objects.

Both of the tests I added still fail because they need a JWT token to access the resource. I suppose adding a test such as should error without JWT token would be useful as well.

Globegitter commented 9 years ago

@mgenev You should be abel to make a new branch and then PR to barrel-test rather than master. As far as I remember on the top of the 'PR window' there are dropdowns where you can change the master branch to any other branch.