search

mgenev / how-to-sane

A demonstration of how to use the SANE stack
http://howtosane.ninja
MIT License
163 stars 22 forks source link

Code did not pass lint rules #73

Closed alaaelotmani closed 9 years ago

alaaelotmani commented 9 years ago

Cloned the repository, bower & npm both client and server, everything is up to date, I am on Kubuntu 14-04. I have errors when sane up : Code did not pass lint rules server | /home/alaa/workspace/how-to-sane/server/api/controllers/AppController.js server | 20:17 error Missing space before function parentheses space-before-function-parentheses server | 21:19 error Use path.join() or path.resolve() instead of + to create paths no-path-concat server | 36:21 error Missing space before function parentheses space-before-function-parentheses server | 38:3 error Unexpected trailing comma comma-dangle server | 39:1 error Newline required at end of file but not found eol-last server | server | /home/alaa/workspace/how-to-sane/server/api/controllers/AuthController.js server | 12:19 error Missing space before function parentheses space-before-function-parentheses server | 14:6 error Expected indentation of 6 characters indent server | 15:8 error Expected indentation of 8 characters indent server | 16:8 error Expected indentation of 8 characters indent server | 16:12 error 'User' is not defined no-undef ... Did I miss something ?

mgenev commented 9 years ago

No, you are correct. This is because, originally sails doesn't ship with a linter and eslint added to this project about 2 weeks ago and we haven't had a chance to revisit and fix the errors. The code works.

mgenev commented 9 years ago

This is a dup of https://github.com/mgenev/how-to-sane/issues/35 so closing.