ptrks commented 4 years ago

Addressed issues related to the 3 failing and 1 error when running unit tests.

The first major group of errors had to do with accessing the deprecated node property, which is now nodes. The second error related to a unit test attempting to delete the crs property of a geodataframe object. This was solved by setting the property to None which should simulate the same failure behavior.

Please let me know if you have any questions or recommendations on modifications to this PR.

codecov-commenter commented 4 years ago

Codecov Report

Merging #337 into master will not change coverage. The diff coverage is 100.00%.

@@           Coverage Diff           @@
##           master     #337   +/-   ##
=======================================
  Coverage   91.85%   91.85%           
=======================================
  Files          36       36           
  Lines        1436     1436           
=======================================
  Hits         1319     1319           
  Misses        117      117

Impacted Files	Coverage Δ
gerrychain/updaters/locality_split_scores.py	`100.00% <100.00%> (ø)`

Continue to review full report at Codecov.

Legend - Click here to learn more Δ = absolute <relative> (impact), ø = not affected, ? = missing data Powered by Codecov. Last update c87da7e...3b92545. Read the comment docs.

bsuwal commented 3 years ago

A bit late, but thanks so much @ptrks ! Merged!

mggg / GerryChain

Fix errors in unit tests #337

Codecov Report