mggg / GerryChain

Use MCMC to analyze districting plans and gerrymanders
https://mggg.github.io/GerryChain/
Other
132 stars 74 forks source link

#414 Use method in recursive calls to recursive_seed_part_inner #415

Closed mkarrmann closed 1 year ago

mkarrmann commented 1 year ago

See https://github.com/mggg/GerryChain/issues/414 for description of issue.

The solution is self-explanatory.

mkarrmann commented 1 year ago

Something weird is going on with pip install in CI, will have to investigate later...

codecov[bot] commented 1 year ago

Codecov Report

Merging #415 (3a3db2a) into main (a35f7cc) will decrease coverage by 0.14%. Report is 2 commits behind head on main. The diff coverage is 85.24%.

Additional details and impacted files [![Impacted file tree graph](https://app.codecov.io/gh/mggg/GerryChain/pull/415/graphs/tree.svg?width=650&height=150&src=pr&token=mDQkxqhlnr&utm_medium=referral&utm_source=github&utm_content=comment&utm_campaign=pr+comments&utm_term=mggg)](https://app.codecov.io/gh/mggg/GerryChain/pull/415?src=pr&el=tree&utm_medium=referral&utm_source=github&utm_content=comment&utm_campaign=pr+comments&utm_term=mggg) ```diff @@ Coverage Diff @@ ## main #415 +/- ## ========================================== - Coverage 89.00% 88.87% -0.14% ========================================== Files 39 39 Lines 1774 1789 +15 ========================================== + Hits 1579 1590 +11 - Misses 195 199 +4 ``` | [Files](https://app.codecov.io/gh/mggg/GerryChain/pull/415?src=pr&el=tree&utm_medium=referral&utm_source=github&utm_content=comment&utm_campaign=pr+comments&utm_term=mggg) | Coverage Δ | | |---|---|---| | [gerrychain/chain.py](https://app.codecov.io/gh/mggg/GerryChain/pull/415?src=pr&el=tree&utm_medium=referral&utm_source=github&utm_content=comment&utm_campaign=pr+comments&utm_term=mggg#diff-Z2VycnljaGFpbi9jaGFpbi5weQ==) | `88.63% <100.00%> (+1.13%)` | :arrow_up: | | [gerrychain/grid.py](https://app.codecov.io/gh/mggg/GerryChain/pull/415?src=pr&el=tree&utm_medium=referral&utm_source=github&utm_content=comment&utm_campaign=pr+comments&utm_term=mggg#diff-Z2VycnljaGFpbi9ncmlkLnB5) | `74.11% <100.00%> (+0.30%)` | :arrow_up: | | [gerrychain/metagraph.py](https://app.codecov.io/gh/mggg/GerryChain/pull/415?src=pr&el=tree&utm_medium=referral&utm_source=github&utm_content=comment&utm_campaign=pr+comments&utm_term=mggg#diff-Z2VycnljaGFpbi9tZXRhZ3JhcGgucHk=) | `95.00% <100.00%> (+0.55%)` | :arrow_up: | | [gerrychain/partition/assignment.py](https://app.codecov.io/gh/mggg/GerryChain/pull/415?src=pr&el=tree&utm_medium=referral&utm_source=github&utm_content=comment&utm_campaign=pr+comments&utm_term=mggg#diff-Z2VycnljaGFpbi9wYXJ0aXRpb24vYXNzaWdubWVudC5weQ==) | `95.77% <100.00%> (+0.06%)` | :arrow_up: | | [gerrychain/accept.py](https://app.codecov.io/gh/mggg/GerryChain/pull/415?src=pr&el=tree&utm_medium=referral&utm_source=github&utm_content=comment&utm_campaign=pr+comments&utm_term=mggg#diff-Z2VycnljaGFpbi9hY2NlcHQucHk=) | `55.55% <75.00%> (+5.55%)` | :arrow_up: | | [gerrychain/graph/graph.py](https://app.codecov.io/gh/mggg/GerryChain/pull/415?src=pr&el=tree&utm_medium=referral&utm_source=github&utm_content=comment&utm_campaign=pr+comments&utm_term=mggg#diff-Z2VycnljaGFpbi9ncmFwaC9ncmFwaC5weQ==) | `91.17% <92.30%> (+0.05%)` | :arrow_up: | | [gerrychain/tree.py](https://app.codecov.io/gh/mggg/GerryChain/pull/415?src=pr&el=tree&utm_medium=referral&utm_source=github&utm_content=comment&utm_campaign=pr+comments&utm_term=mggg#diff-Z2VycnljaGFpbi90cmVlLnB5) | `81.29% <66.66%> (-1.20%)` | :arrow_down: | ------ [Continue to review full report in Codecov by Sentry](https://app.codecov.io/gh/mggg/GerryChain/pull/415?src=pr&el=continue&utm_medium=referral&utm_source=github&utm_content=comment&utm_campaign=pr+comments&utm_term=mggg). > **Legend** - [Click here to learn more](https://docs.codecov.io/docs/codecov-delta?utm_medium=referral&utm_source=github&utm_content=comment&utm_campaign=pr+comments&utm_term=mggg) > `Δ = absolute (impact)`, `ø = not affected`, `? = missing data` > Powered by [Codecov](https://app.codecov.io/gh/mggg/GerryChain/pull/415?src=pr&el=footer&utm_medium=referral&utm_source=github&utm_content=comment&utm_campaign=pr+comments&utm_term=mggg). Last update [04ff4f9...3a3db2a](https://app.codecov.io/gh/mggg/GerryChain/pull/415?src=pr&el=lastupdated&utm_medium=referral&utm_source=github&utm_content=comment&utm_campaign=pr+comments&utm_term=mggg). Read the [comment docs](https://docs.codecov.io/docs/pull-request-comments?utm_medium=referral&utm_source=github&utm_content=comment&utm_campaign=pr+comments&utm_term=mggg).
mkarrmann commented 1 year ago

Not sure what's going on with codecov, I'm clearly not decreasing test coverage here.

mkarrmann commented 1 year ago

@InnovativeInventor @pjrule FYI, a very simple bug fix. A unit test to test the change is included.