mggg / VoteKit

A Swiss Army Knife for computational social choice research
https://votekit.readthedocs.io/en/latest/
MIT License
11 stars 13 forks source link

stv run election w/tests #26

Closed jgibson517 closed 1 year ago

jgibson517 commented 1 year ago

Hi James,

This PR has the fully implemented STV class with an initial batch of tests. One question I had regarding tests for election, since were assuming preference profiles will be cleaned, do you think its worth writing tests that handles profiles with missing ballots, or 'None' candidates?

Also, I cleaned up and added a test for the to_dict() method in the preference profile, which can be reviewed now too!

Thanks!