mggg / ecological-inference

Ecological inference, in Python
MIT License
28 stars 11 forks source link

Start adding tests for two_by_two.py #31

Closed ColCarroll closed 3 years ago

ColCarroll commented 3 years ago

We should set a random seed eventually, but this will make sure that the scipy implementation here at least matches the theano implementation. I've heard some people do not find theano.scan totally easy to write and understand, so this seems like a worthwhile test to have!

You might take a careful look at how I wrote down the data generating process, and either loosen it up, or tighten it up if it is not a reasonable one!

karink520 commented 3 years ago

This looks great!