Consolidating boxplots and kdes for rxc and 2x2

karink520 commented 3 years ago

Changed TwoByTwoEI’s plot_kde() and plot_boxplot() methods to rely on the same plot_util functions as the analogous RxC methods (plot_kdes() and plot_boxplots()), instead of their own 2x2-specific versions (which we shouldn't need to have)
Note: TwoByTwoEI’s plot_summary() still uses the two-by-two specific kde and boxplot, so these aren't totally factored out yet - will put in another PR for that last bit today once it's done

ALSO *Added examples in the notebooks of how you can adjust parameters like number of draws, number of chains, etc.

gabeschoenbach commented 3 years ago

Looks good! I see that show_first_plot_only shows up in the docstring of plot_kdes() but not in the function definition — that's just stubbed out for a future PR, I assume?

karink520 commented 3 years ago

Looks good! I see that show_first_plot_only shows up in the docstring of plot_kdes() but not in the function definition — that's just stubbed out for a future PR, I assume?

Thanks for catching this!

mggg / ecological-inference

Consolidating boxplots and kdes for rxc and 2x2 #40