mggg / ecological-inference

Ecological inference, in Python
MIT License
28 stars 11 forks source link

Add non-candidate names option to candidate of choice reporting. #53

Closed jenni-niels closed 3 years ago

jenni-niels commented 3 years ago

This PR updates the candidate_of_choice_report and candidate_of_choice_polarization_report functions in the RxC model to take an optional parameter (a list of non-candidate names such as an abstain column) to be omitted in the calculation of candidates of choice.

karink520 commented 3 years ago

Looks great! Thanks JN!

(I'm ignoring the linting issue right now b/c my last PR failed the linter too, so I'll just fix whatever's going on with both of those together)