search

mggg / ecological-inference

Ecological inference, in Python
MIT License
28 stars 11 forks source link

Shape comments and arguments #93

Closed karink520 closed 2 years ago

karink520 commented 2 years ago

Fixes #91

Fixing the shape argument (and associated comments) for the observed multinomial draws of votes (correct shape is num_precincts x num_columns) in the r by c models. Note: I'm not totally sure why this argument is necessary, since this is the observed variable (so has access to the shape of the observations), and it seemed to get ignored in previous runs. However, omitting the shape argument entirely seems to leads to errors when using the latest version of pymc3 (but not in version 3.9.3). This PR also updates the r by c tests to include an example with r not equal to c.

gabeschoenbach commented 2 years ago

huh, weird that there are errors if its removed altogether! but this is a good catch :)