search

mgiang2015 / pe

0 stars 0 forks source link

Undo command undid p-edit command #1

Open mgiang2015 opened 4 years ago

mgiang2015 commented 4 years ago

Undo command undid p-edit command.

Steps to reproduce:

  1. add schedule through command a-schedule start/2020-12-25 08:00 end/2020-12-25 12:00 pt/1 d/Medical checkup t/LowPriority
  2. Edit patient's name with p-edit 1 n/Editted Alex Yeoh
  3. Execute undo

Expected:

  1. Appointment disappears.
  2. Patient's name stay the same as Editted Alex Yeoh (Documentation says undo does not work on p-edit command).

Reality:

  1. Appointment is now lost, cannot view even through a-list.
  2. Patient's name changes back to Alex Yeoh No More.

a-schedule start/2020-12-25 08:00 end/2020-12-25 12:00 pt/1 d/Medical checkup t/LowPriority Screenshot 2020-11-13 at 4.26.54 PM.png

p-edit 1 n/Editted Alex Yeoh Screenshot 2020-11-13 at 4.27.41 PM.png

undo Screenshot 2020-11-13 at 4.27.55 PM.png

a-list Screenshot 2020-11-13 at 4.28.40 PM.png

nus-pe-bot commented 4 years ago

Team's Response

Accepted bug.

However, due to the fact that undo is uncompatible with 'p-edit', users are unlikely to enter the commands in this(undo after p-edit) that is shown in this bug report. The impact of bug can easily be removed through the use of 'a-delete'. Therefore, we have lowered the severity to 'Low'.

Items for the Tester to Verify

:question: Issue severity

Team chose [severity.Low] Originally [severity.Medium]

Reason for disagreement: Thank you for the response. I think this is of Medium severity because the product still functions properly, however it will cause occasional inconvenience to users in the form of confusion.

Specificly, when user forgets that undo is disabled for p-edit. This might happen occasionally as users tend to generalise undo for all commands that change information of the app.

Maybe an undo right after p-edit can result in a different success message, informing that p-edit was not undone but the command after p-edit instead? Nevertheless, seeing information changing unexpectedly without clear reasons to the users is the reason why I think this bug is of Medium severity.