search

mgiang2015 / pe

0 stars 0 forks source link

a-complete changes a missed appointment to not missed #2

Open mgiang2015 opened 3 years ago

mgiang2015 commented 3 years ago

A past record Missed is changed from Yes to No when set to completed.

Reproduce:

  1. Past appointment Feb 05 2020 is set at index 1.
  2. Run a-complete 1.

Expected: Missed: Yes Completed: Yes

Got: Missed: No Completed: Yes

There is error in the success message as well. I think isCompleted should be true instead of false.

Screenshot 2020-11-13 at 4.44.04 PM.png

Screenshot 2020-11-13 at 4.44.22 PM.png

nus-pe-bot commented 3 years ago

Team's Response

Thanks for your feedback, but rejected.

This was an intentional feature as part of how the isMissed and isCompleted status works with each other, which is that an appointment can never be both missed and completed at the same time. We made this design choice as it does not logicaly make sense for an appointment to be both missed and completed at the same time. This design choice is also reflected on our missed feature where all appointments that have been completed will not be set as missed.

The reason that we allow old appointments that have been labelled as missed to be overrided as completed is because users can easily forget to set an apointment as complete. This allows them to correct this mistake.

Items for the Tester to Verify

:question: Issue response

Team chose [response.Rejected]

Reason for disagreement: [replace this with your explanation]