mgiang2015 / pe

0 stars 0 forks source link

Undo with p-edit causes false medical records #3

Open mgiang2015 opened 3 years ago

mgiang2015 commented 3 years ago

Steps to reproduce: ( Already have: 2 appointments for Bernice Yu )

  1. Add another appointment for Bernice Yu through a-schedule start/2020-11-18 08:00 end/2020-11-18 12:00 pt/2 d/Medical checkup t/LowPriority

  2. Edit Bernice Yu's name p-edit 2 n/Bernice Edit Name

  3. undo

Expected:

  1. Appointment on 2020-11-18 for a-schedule disappears.
  2. Patient 2's name stays as Bernice Edit Name.

Result:

  1. Appointment on 2020-11-18 disappears.
  2. Patient's name on record reverts back to Bernice Yu.
  3. Medical Records with wrong names present on dashboard.

Screenshot 2020-11-13 at 5.08.21 PM.png Screenshot 2020-11-13 at 5.08.39 PM.png Screenshot 2020-11-13 at 5.09.07 PM.png

Screenshot 2020-11-13 at 5.09.17 PM.png

nus-pe-bot commented 3 years ago

Team's Response

Accepted bug.

However, due to the fact that undo is uncompatible with 'p-edit', users are unlikely to enter the commands in this(undo after p-edit) that is shown in this bug report. The impact of bug can easily be removed through the use of 'a-delete'. Therefore, we have lowered the severity to 'Low'.

Items for the Tester to Verify

:question: Issue severity

Team chose [severity.Low] Originally [severity.Medium]

Reason for disagreement: Thank you for the response. I think this is of Medium severity because the product still functions properly, however it will cause occasional inconvenience to users in the form of confusion.

Specificly, when user forgets that undo is disabled for p-edit. This might happen occasionally as users tend to generalise undo for all commands that change information of the app.

Maybe an undo right after p-edit can result in a different success message, informing that p-edit was not undone but the command after p-edit instead? Nevertheless, seeing information changing unexpectedly without clear reasons to the users is the reason why I think this bug is of Medium severity.