search

mgiang2015 / pe

0 stars 0 forks source link

Patient word missing in class names in DG #7

Open mgiang2015 opened 4 years ago

mgiang2015 commented 4 years ago

EditCommandParser should be PatientEditCommandParser.

Screenshot 2020-11-13 at 5.36.44 PM.png

FindCommandParser should be PatientFindCommandParser

Screenshot 2020-11-13 at 5.36.52 PM.png

As you have 2 types of object to deal with, EditCommandParser and FindCommandParser might be mistaken for the one for appointments.

nus-pe-bot commented 4 years ago

Team's Response

Rejected.

The naming of the classes is accurate to our codebase, however, we do agree that renaming might provide clarity.

Items for the Tester to Verify

:question: Issue response

Team chose [response.Rejected]

Reason for disagreement: [replace this with your explanation]