search

mgieseki / dvisvgm

A fast DVI, EPS, and PDF to SVG converter
https://dvisvgm.de
GNU General Public License v3.0
310 stars 34 forks source link

Cleanup obsolete m4 dist hack #202

Closed thesamesam closed 1 year ago

thesamesam commented 2 years ago

autoconf & automake, at least nowadays, handle including m4/ correctly in dist tarballs (from make dist).

Previously, dist tarballs lacked m4/ax_*.m4 and therefore autoreconf -fi would break the Makefile with:

make[3]: Entering directory '/var/tmp/portage/app-text/dvisvgm-2.14-r1/work/dvisvgm-2.14/libs/clipper'
Makefile:664: *** missing separator.  Stop.

On that line is an unexpanded @CODE_COVERAGE_RULES@.

Bug: https://bugs.gentoo.org/879539 Signed-off-by: Sam James sam@gentoo.org

mgieseki commented 1 year ago

Thank you for working on this and for providing the patches! Since I was pretty busy with my day job, I wasn't able to review them earlier. After having a closer look at the changes now, I couldn't find any problems and everything looks good so far.

thesamesam commented 1 year ago

No worries at all, thank you!