mgifos / quick-plan

Defines and schedules Garmin workouts
Apache License 2.0
137 stars 23 forks source link

support min/mi paces #19

Closed leingang closed 6 years ago

leingang commented 6 years ago

First, let me say this is a cool project! Thanks for getting it started.

I am from the USA and we keep paces in minutes per mile. When I imported and scheduled a week of workouts, I noticed that my paces got interpreted as minutes per kilometer.

I notice that the grammar supports miles as a distance, but it seems only min/km as pace. Could there be a way to support min/mi too?

Thanks for considering.

leingang commented 6 years ago

Workaround: convert the pace in advance.

mgifos commented 6 years ago

Hi, thanks for your support.

I have just returned from a vacation. We'll figure something out when it comes to syntax of different pace units. Your suggestions sound reasonable to me, I like implicit command line config and explicit notation in CSV file. Maybe we can support it both. I'll get back to this soon.

leingang commented 6 years ago

Thanks! There is also a Garmin user preference for preferred distance units. If that could be accessed by API, it might be the smoothest way.

mgifos commented 6 years ago

Do you know perhaps which endpoint of the API provides this?

mgifos commented 6 years ago

I investigated this and I couldn't find the API endpoint that provides this and that works, so we'll have to fallback to the initial suggestion - either to add unit of measure in the workout definitions or to add an additional config, or both.