mgijax / mammalian-phenotype-ontology

Standard terms for annotating mammalian phenotypic data
Creative Commons Attribution 4.0 International
19 stars 6 forks source link

Align acidemia, alkalemia, acidosis, alkalosis with HPO #4012

Open rays22 opened 3 months ago

rays22 commented 3 months ago

The relevant EQs have been fixed in HPO.

It would be great to alight the EQs of the related MP terms:

  1. increased acidity

    • MP:0003030 acidemia
    • MP:0003031 acidosis
    • suggested EQ (use blood or bodily fluid as appropriate):
      'has part' some 
      ('increased acidity'
       and ('characteristic of' some blood/bodily fluid)
       and ('has modifier' some abnormal))
  2. decreased acidity

    • MP:0003029 alkalemia
    • MP:0003028 alkalosis
    • suggested EQ (use blood or bodily fluid as appropriate):
      'has part' some 
      ('decreased acidity'
       and ('characteristic of' some blood/bodily flluid)
       and ('has modifier' some abnormal))
anna-anagnostop commented 3 months ago

Changed EQs for acidemia, acidosis, alkalemia and alkalosis. Made acidemia a child of acidosis, and alkalemia a child of alkalosis. Removed increased circulating methylmalonic acid level MP:0030630 from under acidemia CHECK Need to review other child terms of acidosis and check EQ for lactic acidosis

sbello commented 3 months ago

Acidosis and alkalosis are defined as increase in blood and tissues so we used multicellular organism in the eq. This is also why these are not parents of alkalemia and acidemia as this are limited to the blood.

Discussed on 8/26 - should the and really be and/or in the definitions. If it should be and/or the terms alkalemia and acidemia could be made child terms of these. If it is really 'and' then we would keep the current placement.