mgijsberti / synoptic

Automatically exported from code.google.com/p/synoptic
0 stars 0 forks source link

GWT Model Tab: Allow a specified path to be displayed on the model. #163

Closed GoogleCodeExporter closed 9 years ago

GoogleCodeExporter commented 9 years ago
This could be done by highlighting the path through the model, or creating an 
overlay, etc.

Original issue reported on code.google.com by a.w.davi...@gmail.com on 16 Nov 2011 at 2:22

GoogleCodeExporter commented 9 years ago
[deleted comment]
GoogleCodeExporter commented 9 years ago
Were a user to select a given collection of nodes, there may be multiple paths 
through said nodes.  It would be useful to allow a single overlay of a given 
path ('path' being a series of executions from the log) in order to give more 
visual context to the user.  Perhaps there were paths the user was not aware 
of, or perhaps there was a relation inferred in the simplified graph that there 
was no path for in the original log (a "synthetic path").  This would make it 
easier to visualize for the user.

Original comment by a.w.davi...@gmail.com on 16 Nov 2011 at 6:42

GoogleCodeExporter commented 9 years ago
To do this, one might iterate through the path provided to:

a) Find the corresponding partition for the given log line displayed by the 
model.
b) Find the next partitioned node in the corresponding line of the log (one 
after the one found in a). 
c) "Activate" the edge between the two nodes (this could be done by storing 
something related to the edge in memory, like possibly a hash code).
d) Create a visual cue that highlights the specified edge.
e) Start again back at 'b' for the next log line until the last node in the 
path is found.

Then, when selecting a different path, this would all be set back to normal 
(using whatever sort of reference to the previous edges so they can be set back 
to normal), and done over again.

Original comment by a.w.davi...@gmail.com on 16 Nov 2011 at 6:48

GoogleCodeExporter commented 9 years ago

Original comment by a.w.davi...@gmail.com on 31 Jan 2012 at 8:13

GoogleCodeExporter commented 9 years ago
I think this would be good to know for future reference when dealing with the 
way Dracula handles drawing edges.  When changing the style of the given edge 
(say, a someone were to write edge.style.fill = "blue"), when the edge is 
redrawn, an inner object that may contain one or two svg paths is updated.  
This inner object (called connection) is what handles the actual appearance of 
the edge.  Dracula (currently) handles this style change of the "fill" 
attribute by creating a second svg path in the "connection" object, called 
connection.bg, which is what "fills" the edge's color when drawn on a Raphael 
canvas.  However, there seems to be no discernible update when changing the 
edge's fill attribute to something like "none" or removing it entirely.  So, 
this meant the highlighting had to be done manually on these inner objects.  
So, if any more visual work is to be done on these edges, it would be very good 
to know about this to save time. 

Original comment by a.w.davi...@gmail.com on 6 Feb 2012 at 5:08

GoogleCodeExporter commented 9 years ago
[deleted comment]
GoogleCodeExporter commented 9 years ago
Solution in revision 4ce187fa6305. Please review.

Original comment by a.w.davi...@gmail.com on 6 Feb 2012 at 5:09

GoogleCodeExporter commented 9 years ago
Code looks good. It would help to include the comment about connection objects 
in the code as this will come up in the future. Please do this, and then I'll 
close the issue.

Original comment by bestchai on 6 Feb 2012 at 6:25

GoogleCodeExporter commented 9 years ago

Original comment by bestchai on 6 Feb 2012 at 6:35

GoogleCodeExporter commented 9 years ago
Comments have been added.  Solution in 652a888d99eb.  Please review.

Original comment by a.w.davi...@gmail.com on 7 Feb 2012 at 3:55

GoogleCodeExporter commented 9 years ago
woops!  revision 652a888d99eb.

Original comment by a.w.davi...@gmail.com on 7 Feb 2012 at 3:56

GoogleCodeExporter commented 9 years ago
Merged into default in revision babb8f354a8a

Original comment by bestchai on 7 Feb 2012 at 9:50