search

mgildea / Multi-Step-Form-Js

Multi Step Form with jQuery validation
MIT License
49 stars 25 forks source link

Enhancement request. #8

Open nmanikanta101990 opened 7 years ago

nmanikanta101990 commented 7 years ago

I am trying this in my form and i need to add dynamic msf-view div's at the last of the form. Is there any way to do that?

For example if user selects a button I want to add a view at the last.

lvmajor commented 7 years ago

Have you found a solution to your question? I just noticed it in my notifications that you closed the issue and I wonder if you just let it be or if you made something up to make it work?

nmanikanta101990 commented 7 years ago

Hi

I made some modifications to your js extension to help out the scenario that I am looking for.

Thanks Manikanta

On Tuesday, July 11, 2017, Os1r1s110 notifications@github.com wrote:

Have you found a solution to your question? I just noticed it in my notifications that you closed the issue and I wonder if you just let it be or if you made something up to make it work?

— You are receiving this because you modified the open/close state. Reply to this email directly, view it on GitHub https://github.com/mgildea/Multi-Step-Form-Js/issues/8#issuecomment-314589829, or mute the thread https://github.com/notifications/unsubscribe-auth/AbiydnNczGAoQgNiKDPLqeEyOW1nqY7Oks5sM_Z8gaJpZM4ORUBs .

-- Maηιкαηтα.N

lvmajor commented 7 years ago

Ok nice to know you found a way to do what you wanted. I don't know if that's something the project maintainer would be interested in, would you be willing to open a PR if that's the case?

Also, to give credit where credit is due, I must mention it is by all means not my extension, I only participated a bit by providing some ideas but most of the work has been done by @mgildea.

nmanikanta101990 commented 7 years ago

I can definitely do a PR. But the code is in my office laptop which I cannot do a PR from it. But I can create the same scenario in my personal laptop and will create the request.

Also thanks for both of you guys as the extension is super helpful and made my job easy.

On Tue, Jul 11, 2017, 17:35 Os1r1s110 notifications@github.com wrote:

Ok nice to know you found a way to do what you wanted. I don't know if that's something the project maintainer would be interested in, would you be willing to open a PR if that's the case?

Also, to give credit where credit is due, I must mention it is by all means not my extension, I only participated a bit by providing some ideas but most of the work has been done by @mgildea https://github.com/mgildea.

— You are receiving this because you modified the open/close state. Reply to this email directly, view it on GitHub https://github.com/mgildea/Multi-Step-Form-Js/issues/8#issuecomment-314591548, or mute the thread https://github.com/notifications/unsubscribe-auth/Abiydor-iU4y0S6fdZSszo2bYML26tzsks5sM_jLgaJpZM4ORUBs .

mgildea commented 7 years ago

I think this definitely a valid use case and a great idea to add to this project. Looking forward to seeing your implementation of this. Create a PR whenever you are ready.

nmanikanta101990 commented 7 years ago

Hi @mgildea ,

I sent a PR for the issue with a new file added to it. Check the code and if you are good with the changes copy the file content to the actual file.