mglaman / conductor

A Composer user interface built using Electron.
MIT License
142 stars 12 forks source link

Clicking on a package while another packageWindow is open fails to open new window #39

Closed daggerhart closed 7 years ago

daggerhart commented 7 years ago

Title says it all, but here it is a bit more unpacked.

How to see the problem:

  1. Open a project
  2. Click on a package (package window pops up)
  3. Move the packageWindow over to the side
  4. Click on another package in the projectWindow

Result: Existing packageWindow goes away, a new packageWindow does not appear.

I did a little debugging but quickly hit a wall. Turns out that in the above scenario, when you click on the 2nd package, the "lock" returned by activeProject.getLock() here is null.

I tried a few things blindly (not understanding all of this) such as activeProject.refreshData() before getLock(). Though that didn't work, I was able to see this error in the console: Electron Helper[89990:5469284] Couldn't set selectedTextBackgroundColor from default ()

daggerhart commented 7 years ago

Resolved w/ #46