search

mglaman / drupalorg-cli

A command line tool for interfacing with Drupal.org
126 stars 31 forks source link

Include commit links for maintainer:release-notes #37

Open colans opened 5 years ago

colans commented 5 years ago

It would be nice if commit links could be added to mrn just like Git Release Notes for Drush does.

greggles commented 5 years ago

Which commit links are these? It links to the issue, which links to the commits, so at least there's a workaround.

mglaman commented 5 years ago

🤔This is a feature request for --commit-links, correct?

    // If the command was invoked with the --commit-links option
    if (!empty($commit_path)) {
      $item .= ' (<a href="' . $commit_path . $hash . '" title="View commit">#</a>)';
    }

It would append (HASH) after the issue. @colans is this the request?

Relevant code: https://git.drupalcode.org/project/grn/blob/7.x-2.x/grn.drush.inc#L298

colans commented 5 years ago

@mglaman Yes, exactly. It should be noted that these URLs changed recently now that the code is on GitLab. (Because of this, and earlier changes to d.o's infrastructure, this is actually broken in grn as well. See Commit links are incorrect for details.)

mglaman commented 5 years ago

Thanks for confirming and linking to the relevant issue! This shouldn't be too hard to implement.