search

mglaman / drupalorg-cli

A command line tool for interfacing with Drupal.org
127 stars 32 forks source link

Coding standard - indent #60

Closed hansfn closed 4 years ago

hansfn commented 4 years ago

I have recently written some patches and noticed that in most files the indent was 2 spaces (Drupal standard), but in some files it was 4 space - random examples: src/Cli/Command/Issue/Link.php and src/Cli/Command/Command.php

I suggest providing an .editorconfig file. Maybe copy the one from Drupal core (and remove the composer block)?

hansfn commented 4 years ago

Thanks, that fixes it for all new commits / pull requests, but maybe we should fix all existing files too? Minor importance.

mglaman commented 4 years ago

I actually added phpcs and gave it a clean up prior to this

hansfn commented 4 years ago

OK, maybe I looked to quickly at the files.

There are some white space issues with comments - see for example src/Cli/Command/Issue/Interdiff.php And some white-space inconsistency when defining commands. Whatever ;-)

mglaman commented 4 years ago

Yeah, I noticed that. phpcbf got funky 😱 adjusted them as I hit them