search

mglaman / phpstan-drupal

Extension for PHPStan to allow analysis of Drupal code.
https://phpstan-drupal.mglaman.dev/
MIT License
198 stars 76 forks source link

InstallerExistingConfigTestBase is going to be deprecated #780

Closed nlighteneddesign closed 3 months ago

nlighteneddesign commented 4 months ago

Issue: https://www.drupal.org/project/drupal/issues/3455820 Change Notice: https://www.drupal.org/node/3460001

Rule: https://github.com/mglaman/phpstan-drupal/blob/main/src/Rules/Drupal/Tests/BrowserTestBaseDefaultThemeRule.php#L74

mglaman commented 4 months ago

If the class is ragged as deprecated, this should just work and throw an error about extending the class.

nlighteneddesign commented 4 months ago

Yes, the deprecation will work, but you'll need to update the rule I linked for the new class, I think I can create an MR as the other issue gets closer.

nlighteneddesign commented 4 months ago

Here is the PR https://github.com/mglaman/phpstan-drupal/pull/781

mglaman commented 4 months ago

Oh I see, now