Update phpstan/phpstan related dependencies to ^2.0"

Boegie commented 2 weeks ago

Naive first stab

mglaman commented 2 weeks ago

I'll probably want to open a 2.x branch as well. Thanks for trying at this.

Boegie commented 1 week ago

No worries, I'll chip away at this for an hour 2 from now.

Boegie commented 1 week ago

Ok, so this was more of a grind than actually Big Brain stuff.

I would recommend:

Going over the identifiers that were (forcefully) added. There are a lot of them and they might not be consistent.
The changes in .github/workflows/php.yml can be reverted when drupal core includes phpstan/phpstan:^2.0
Replacing all @phpstan-ignore next-line nuke-em-all lines with the more targeted @phpstan-ignore [identifier] in a separate MR. I found some "hidden sins" whilst creating this MR.

Also:

A new branch might be a nice clean cut-off point to drop D9 support?

mglaman commented 1 week ago

A new branch might be a nice clean cut-off point to drop D9 support?

We can say 2.x drops Drupal 9 support, as a follow up to his PR.

Boegie commented 1 week ago

I appreciate it. I literally fell asleep at my laptop 2 times while working on that.

I couldn't handle in batches longer than one hour, extremely grindy stuff

mglaman commented 1 week ago

Thanks for this!!

mglaman / phpstan-drupal