search

mglaman / platform-docker

Local development tool for PHP platforms using Docker Compose
GNU General Public License v2.0
46 stars 16 forks source link

Drush runner only kind of works #41

Open mglaman opened 8 years ago

mglaman commented 8 years ago

So far it's only useful for single commands, adding parameters makes it complain.

mofakhamr commented 8 years ago

After doing a platform get and platform build, I performed a platform-docker init and got my docker machines.. happy days. However, I'm unable to run Drush commands such as "drush rr" or "drush sqlc" and cache-clears only allowed clearing of the drush cache.

I've actually managed to get the above commands working fine - please see my fork and let me know if you'd like me to do a pull request - or please do tell me if I've made an error and this issue is not what I'm describing.

The changes I've made: https://github.com/mofakhamr/platform-docker/commit/1a80bd34addd7d426d511cc996ce0dc6e6b3ca33

mglaman commented 8 years ago

I'd say open a PR! Makes sense.

This issue is in reference to DrushCommand, a way to run drush on local instance without needing to have your docker-machine info exported

mofakhamr commented 8 years ago

It's worth mentioning that I run Lubuntu as my host - so the containers don't need a VM. I don't think my changes will break win/mac hosts but certainly it gets my existing drupal 7 platform instance working and allows drush commands to run.

mglaman commented 8 years ago

Cool, I'm going to test this. To be honest half the reason I wrote this tool was being too lazy to run the eval env command on my Mac :P I bounce between my iMac and Linux laptop often.

I've been busy with work but will test it out. Knowing someone else uses this will boost my effort on it.