search

mgmeyers / obsidian-smart-typography

Converts quotes to curly quotes, dashes to em dashes, and periods to ellipses
GNU General Public License v3.0
250 stars 11 forks source link

Guillemets and non-breaking spaces #21

Closed KelsoUxlay closed 2 years ago

KelsoUxlay commented 2 years ago

In French, a pair of guillemets requires a non-breaking space following the opening guillemet and a non-breaking space preceding the closing guillemet («  »). This is to prevent an automatic line break at the position of the white space. On a windows keyboard, a non-breaking space can be produced by typing 0160 on the numeric keypad while pressing down the Alt key. For me, ideally, opening a guillemet with << (or with « ) should automaticallly create the guillemet pair, insert 2 non-breaking spaces between the guillemets and position the cursor between the two non-breaking spaces, ready to insert text. In the following example, the cursor should be at the position of the vertical bar : « | » (I have added the vertical bar in the example only to show where the cursor should be located).

mgmeyers commented 2 years ago

@KelsoUxlay Thanks for letting me know! I've added non breaking spaces like you suggested. Let me know if this works as you'd expect.

KelsoUxlay commented 2 years ago

Hello Matthew - Thanks for getting back to me. I have installed the update and restarted Obsidian. May be, the plugin is interfering with another plugin. If I type <<, the two caracters are converted to «, but I see no spaces, and the closing pair does not appear. If I add the closing >> manually, they are converted to », but no spaces are inserted; I end up with «». If I insert regular spaces and type something inbetween, the spaces are not converted to non-breaking spaces either. Unless I am missing something?

mgmeyers commented 2 years ago

Hmm, just to check, are you on version 1.0.16 of the plugin? Here's what it looks like for me:

https://user-images.githubusercontent.com/2694747/160939472-1b3c3de7-ba46-4407-96d0-dd8b03392ec9.mov

mgmeyers commented 2 years ago

Oh, also, this update doesn't work with the legacy obsidian editor. Are you using that?

KelsoUxlay commented 2 years ago

I confirm 1.0.16 but yes, I use Legacy; I will change the setting

KelsoUxlay commented 2 years ago

Now it works as expected - Real cool - Thanks a lot for the good work!

mgmeyers commented 2 years ago

@KelsoUxlay Just FYI, I've changed back to not including the space by default, but made guillemets configurable so users can add the space if they'd like:

Screen Shot 2022-04-24 at 4 46 02 PM
KelsoUxlay commented 2 years ago

Excellent!

That works well for me

The best of both worlds

KU-)

De : Matthew Meyers @.> Envoyé : 24 avril 2022 19:48 À : mgmeyers/obsidian-smart-typography @.> Cc : KelsoUxlay @.>; Mention @.> Objet : Re: [mgmeyers/obsidian-smart-typography] Guillemets and non-breaking spaces (Issue #21)

@KelsoUxlay https://github.com/KelsoUxlay Just FYI, I've changed back to not including the space by default, but made guillemets configurable so users can add the space if they'd like:

https://user-images.githubusercontent.com/2694747/165001697-433fb7c9-a344-4d73-bb73-3cf89955c272.png

— Reply to this email directly, view it on GitHub https://github.com/mgmeyers/obsidian-smart-typography/issues/21#issuecomment-1107941540 , or unsubscribe https://github.com/notifications/unsubscribe-auth/ASKET6SHH25D7WEJZ7TCZ2DVGXMTJANCNFSM5OPLCF4Q . You are receiving this because you were mentioned. https://github.com/notifications/beacon/ASKET6VE4J4GILHQT4QLPELVGXMTJA5CNFSM5OPLCF42YY3PNVWWK3TUL52HS4DFVREXG43VMVBW63LNMVXHJKTDN5WW2ZLOORPWSZGOIIE5RJA.gif Message ID: @. @.> >