search

mgmeyers / obsidian-smart-typography

Converts quotes to curly quotes, dashes to em dashes, and periods to ellipses
GNU General Public License v3.0
241 stars 11 forks source link

Spaces around guillemets intentional? #23

Closed PeteMichaud closed 2 years ago

PeteMichaud commented 2 years ago

The replacement logic for "<<" puts a space after the character, while the logic for ">>" puts a space before the character. This isn't how quote characters generally work, eg.

«This is a quote»

vs

« This is a quote with spaces for some reason »

I think the logic should produce the first one, not the second one?

mgmeyers commented 2 years ago

@PeteMichaud This was a change I added in response to this issue: https://github.com/mgmeyers/obsidian-smart-typography/issues/21

I'm unfamiliar with how guillemets work, but to make things flexible, I've added a setting to control the output of a guillemet:

Screen Shot 2022-04-24 at 4 46 02 PM

It will now default to no spaces. Let me know if you run into any issues with this.

PeteMichaud commented 2 years ago

Great, thanks so much! I think providing the option is the right move—the many different languages that use the marks all have different rules, so there are valid use cases both with and without the spaces.