mgmeyers / obsidian-style-settings

A dynamic user interface for adjusting theme, plugin, and snippet CSS variables within Obsidian
GNU General Public License v3.0
1.03k stars 95 forks source link

HUGE BUG: Background is Dark-Purple instead of BLACK on Many Dark Themes ! #141

Open washere opened 7 months ago

washere commented 7 months ago

I'm seeing this on 4 Android phones, 2 are folding, happens on all!

Many of us change themes for each repository. Most developers & coders user black background themes in ide, text editors, apps etc, almost all coders use dark themes, except newbies going blind.

Took me a while, but I tracked the big to this. Most dark & black background themes get corrupted with this plugin.

Not only it turns background on most BLACK & dark themes to dark purple: But also turns most interface elements the same terrible color.

Even changing the theme's background options manually to black #000000 will not get rid of that horrible purplish color that dominates all interface elements & background.

For example try the wonderful theme "APATHEIA" without this plugin enabled. You get fantastic colors on black background, frames, etc etc. Enable this plugin & suddenly the horrible purple destroys everything, like invasion of the body snatchers from planet Zog!

A minority of black & dark themes withstand the attack of this terrible bug but most are completely ruined. Because their color palette was not designed for this overall purplish mist nightmare.

Without fixing this intrusive disastrous bug, this plugin is not only malfunctioning but it's a big problem.

While searching for a few days to track the problem, I've seen many complaints on obsidian forum & actually most don't realize where this purple bug virus is coming from.

Please keep this open so others can get help. Please test with Apatheia & most Dark & black & AMOLED themes, toggle plugin on & off & see background in editor change. Until it's fixed.

If you test with one or few dark themes & you don't see the problem, it's because as I said a minority of black & dark themes withstand this infection. Most can't.

Thanks.

ArtexJay commented 5 months ago

Took me a while, but I tracked the big to this. Most dark & black background themes get corrupted with this plugin.

Not only it turns background on most BLACK & dark themes to dark purple: But also turns most interface elements the same terrible color.

I'm not the dev for Style Settings, but curious to check this out as a theme creator myself.

I tried it on desktop, by default it has a purplish tinge (with and without style settings), I also checked the preview of Apatheia which has a purplish tinge again. See the color in the following screenshot: image

While on mobile I noticed as you've said the color shifts when style setting is enabled,

Style Settings not enabled: Screenshot 2023-12-24 052854

Style Settings enabled: Screenshot 2023-12-24 053021

Looking in inspect element this is what I found, when Style settings is not enabled, the general color for background uses the default Obsidian colors the one you prefer, but when Style Setting is enabled, this line ".theme-dark.a-theme-apatheia" kicks in allowing the theme to override the default mobile colors on the phone. The theme itself doesn't have ".is-mobile.theme-dark" or any mobile specific clauses to correct the incorect colors from showing by default.